Test updated build with docker-compose

[joshmoore]

Beyond just using make for building a set of paired omero-web and omero-web-standalone images, this allows building within a self-contained docker-compose.yml.

see: https://github.com/openmicroscopy/omero-web-docker/pull/28

Questions:

• [ ] default server to point at
• [ ] whether or not to include a server & db container

Testing:

• choose your server list (updating .env or setting the environment variable
• run docker-compose up -d
• check that you are using the latest build from merge-ci

cc: @manics @will-moore

[rgozim]

This works on my machine, however there could be a potential build/run order issue. There is a github issue discussing how docker-compose doesn't support this use case.

The depends_on option is potential solution, however again, there is a github issue advising against it.

@manics might have more to say on it.

[manics]

If the main aim is to test prebuilt merge-ci and latest-ci builds we could make it even easier for people by ensuring the containers are already built by devspace, either by

• get travis-ci to build https://github.com/snoopycrimecop/omero-web-docker and push the required images to https://hub.docker.com/r/snoopycrimecop/omero-web/
• Build and push from devspace, since it already has a docker node https://github.com/ome/devspace/tree/0.12.0/docker

Another advantage is that you could test this using our production OMERO docker-compose.yml files by overriding the images instead of two more docker-compose.yml files for omero-web and omero-server.

[joshmoore]

If the main aim is to test prebuilt merge-ci and latest-ci builds

I think the main driver was to add the necessary configurability to do everything you proposed in the via the makefile in docker-compose.yml itself. In fact, I could see moving away from the makefile in favor of docker-compose as the standard build mechanism. It also makes for a clear documentation of how everything is to be used.

we could make it even easier for people

I can definitely see having both :merge and :latest(-ci?) versions pushed regularly.

instead of two more docker-compose.yml files

Yeah, I'm not overly happy with the degree of cut-n-paste that docker-compose requires in general, but I think there's still value in having these files in the repo, especially if we can get rid of the cut-n-paste in Makefile. When I'm making changes to omero-{web,server}-docker, I often find myself wanting an in-place docker-compose.yml. (I've had local ones multiple times.)

[joshmoore]

Note: the only thing this doesn't easily provide is a way to add more environment variables without modifying the docker-compose.yml itself. If you have ideas on how to add that customization, I'd be interested.

[manics]

I'm still not convinced of the benefit of having a docker-compose.yml file in this repo, but if we're going ahead with it can you look into the potential ordering issue: https://github.com/ome/omero-web-docker/pull/29#issuecomment-496541382 ?

[joshmoore]

@manics, are you referring to https://stackoverflow.com/a/51425060/56887 ? I tried this:

diff --git a/docker-compose.yml b/docker-compose.yml
index 209f9c1..13d2b9e 100644
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -17,10 +17,16 @@ services:
     image: ${REPO}/omero-web-standalone:${PREFIX}
     build:
       context: standalone
+      network: omero
       args:
...
+
+networks:
+  default:
+    name: omero

but it would bump our minimum requirement:

$ docker-compose pull
ERROR: The Compose file './docker-compose.yml' is invalid because:
networks.default value Additional properties are not allowed ('name' was unexpected)
services.web.build contains unsupported option: 'network'

I've not run into any ordering issues, i.e. the state of this PR has always worked for me.