ome / omero-web-docker

OMERO.web production docker image
https://hub.docker.com/r/openmicroscopy/omero-web/
BSD 2-Clause "Simplified" License
6 stars 19 forks source link

Update role for omero-web 5.6.0.dev6 #42

Closed joshmoore closed 4 years ago

joshmoore commented 4 years ago

see: https://github.com/ome/omero-mapr/pull/56#issuecomment-559581474

joshmoore commented 4 years ago
TASK [ome.omero_web : omero web | setup omero web virtualenv3] *****************
fatal: [localhost]: FAILED! => {"changed": false, "cmd": ["/opt/omero/web/venv3/bin/pip", "install", "https://github.com/ome/zeroc-ice-py-centos7/releases/download/0.2.1/zeroc_ice-3.6.5-cp36-cp36m-linux_x86_64.whl", "omero-web==5.6.0-m3", "redis"], "msg": "stdout: Collecting zeroc-ice==3.6.5 from https://github.com/ome/zeroc-ice-py-centos7/releases/download/0.2.1/zeroc_ice-3.6.5-cp36-cp36m-linux_x86_64.whl\n  Downloading https://github.com/ome/zeroc-ice-py-centos7/releases/download/0.2.1/zeroc_ice-3.6.5-cp36-cp36m-linux_x86_64.whl (23.8MB)\nCollecting omero-web==5.6.0-m3\n\n:stderr:   Could not find a version that satisfies the requirement omero-web==5.6.0-m3 (from versions: 5.5.dev1, 5.5.dev2, 5.6.dev1, 5.6.dev2, 5.6.dev3, 5.6.dev4, 5.6.dev5, 5.6.dev6)\nNo matching distribution found for omero-web==5.6.0-m3\nYou are using pip version 9.0.3, however version 19.3.1 is available.\nYou should consider upgrading via the 'pip install --upgrade pip' command.\n"}
manics commented 4 years ago

https://github.com/ome/omero-web-docker/blob/2aad76338fd9472b059ef047c3711126592a95d8/Dockerfile#L19 omero_web_release is set by OMERO_VERSION=5.6.0-m3. Either need to override it or decouple it. (or don't set it)

joshmoore commented 4 years ago

What would you suggest here? This repo should really be green (and usable) before we sign off on https://github.com/ome/ansible-role-omero-web/pull/26

manics commented 4 years ago

Delete

    -e omero_web_release=$OMERO_VERSION \
    -e omero_web_omego_additional_args="$OMEGO_ADDITIONAL_ARGS"

completely?

manics commented 4 years ago

E.g. see (now out of date) https://github.com/ome/omero-web-docker/pull/38/files

manics commented 4 years ago

Also /opt/omero/web/OMERO.web/bin/omero is a python wrapper which sets OMERODIR so if the only thing preventing you from using that was it being a shell script you could try using it again.

joshmoore commented 4 years ago

Merging with the version "bump" and releasing as 5.6.0-m3-1, though we'll likely need to reconsider the version numbering.