search

ome / omero-web-docker

OMERO.web production docker image
https://hub.docker.com/r/openmicroscopy/omero-web/
BSD 2-Clause "Simplified" License
6 stars 19 forks source link

Push to dockerhub #63

Closed jburel closed 2 years ago

jburel commented 2 years ago

https://hub.docker.com/r/openmicroscopy/omero-web/ and https://hub.docker.com/r/openmicroscopy/omero-web-standalone/ have not been updated since the release of omero-web 5.11 This PR automatically will push to dockerhub when a tag is pushed to this repo

cc @sbesson @will-moore

Tested using my account see https://hub.docker.com/r/jburel/omero-web/ and https://hub.docker.com/r/jburel/omero-web-standalone

sbesson commented 2 years ago

I assume the tag still must be created using https://github.com/ome/omero-web-docker/blob/master/Makefile i.e. replacing the variables and effectively, this replaces the docker-build and docker-push steps?

jburel commented 2 years ago

The tag needs to be created and pushed cf. description. The changes follow a similar approach that the one taken in omero-server-docker and replace docker-build/push Another option could be to post an event from omero-web when a tag is pushed and listen to that event here but it is outside the scope of this PR

jburel commented 2 years ago

I realised that afterwards. I am going to slip things up

jburel commented 2 years ago

@sbesson problem is now fixed https://hub.docker.com/repository/docker/jburel/omero-web https://hub.docker.com/repository/docker/jburel/omero-web-standalone different checksums and sizes.

jburel commented 2 years ago

As indicated previously during discussion, web-standalone should be extracted so we can push a new version each time a new web app included in the standalone image is released. When that is done, we can have a reusable workflow i.e. omero-server-docker and omero-web-docker will follow a similar pattern

sbesson commented 2 years ago

As indicated previously during discussion, web-standalone should be extracted so we can push a new version each time a new web app included in the standalone image is released.

But the extraction will break the workflow that is proposed in this PR. So I guess the question is whether we want to extrac first or capture as an issue and come back to it?

jburel commented 2 years ago

If we extract, of course the workflow will need to be reviewed. The proposed changes automate the build/push of the images. I think we can extract afterwards and adjust accordingly

jburel commented 2 years ago

https://github.com/ome/omero-web-docker/issues/53 already captures the release of apps problem. i did not notice the issue

jburel commented 2 years ago

The commit 6d985b7 adds labels cf. in https://github.com/ome/omero-server-docker/issues/57. More labels than the 3 current listed in the Dockerfile are added.

List of labels:

org.opencontainers.image.title=omero-web-docker
  org.opencontainers.image.description= OMERO.web production docker image
  org.opencontainers.image.url=https://github.com/***/omero-web-docker
  org.opencontainers.image.source=https://github.com/***/omero-web-docker
  org.opencontainers.image.version=5.13.0-15
  org.opencontainers.image.created=2022-03-18T11:40:23.[34](https://github.com/jburel/omero-web-docker/runs/5599778430?check_suite_focus=true#step:3:34)5Z
  org.opencontainers.image.revision=6d985b7284edacba4f3d094d43ddeb3c[39](https://github.com/jburel/omero-web-docker/runs/5599778430?check_suite_focus=true#step:3:39)73075f
  org.opencontainers.image.licenses=
jburel commented 2 years ago

Images rebuilt see https://hub.docker.com/repository/docker/jburel/omero-web and https://hub.docker.com/repository/docker/jburel/omero-web-standalone

jburel commented 2 years ago

@sbesson I have cleaned up the LABEL. It will be good to have this PR merged before deploying omero-web so I can tag with a 5.13 web then a Django upgrade image.