search

ome / omero-web-docker

OMERO.web production docker image
https://hub.docker.com/r/openmicroscopy/omero-web/
BSD 2-Clause "Simplified" License
6 stars 19 forks source link

Docker Hub is missing the -0 suffix on the first image for a tag #71

Open manics opened 2 years ago

manics commented 2 years ago

https://hub.docker.com/r/openmicroscopy/omero-web-standalone/tags https://github.com/ome/omero-web-docker/blob/1271c72718409da94c134d025a82f9fb7e09b237/.github/workflows/main.yml#L58-L60 only creates higher-level tags, so if this repository is tagged with 5.14.0 instead of 5.14.0-0 the Docker Hub tags 5.14.0 and 5.14 are created, and 5 is updated.

If the image is later rebuilt and tagged as 5.14.0-1 Docker Hub tags 5.14.0, 5.14 and 5 are updated, but since there was never a 5.14.0-0 tag the original 5.14.0 image is lost.

This also applies to https://hub.docker.com/r/openmicroscopy/omero-server/tags

jburel commented 2 years ago

Thanks for the info. Are you working on that issue in the action?

Checking https://github.com/jupyterhub/action-major-minor-tag-calculator/blob/main/README.md Pushed reference "1.2.3-4" => tags output "[1.2.3-4, 1.2.3, 1.2, 1, latest]"

manics commented 2 years ago

No, I think this is best handled when the GitHub *-docker repository is tagged. Extrapolating a release tag of 5.14.0 to 5.14.0-0 is doable, but since rebuilds of the Docker image will need a -1, -2, ... etc GitHub tag anyway it seems more consistent to start with a -0 GitHub tag.