The original intent of the NonASCIIForm was to support Unicode strings by overriding the CharField validation. Unicode is now natively supported by the Python/Django stack. This commit proposes to drop our intermediate custom class in favor of upstream django.forms.Form. This should incidentally reduce the maintenance burden when upgrading between Django major versions.
Testing:
All places using the legacy base form should be reviewed with this change using both ASCII strings and Unicode strings as inputs. Below is a list of endpoints to review
Fixes #468
The original intent of the NonASCIIForm was to support Unicode strings by overriding the CharField validation. Unicode is now natively supported by the Python/Django stack. This commit proposes to drop our intermediate custom class in favor of upstream
django.forms.Form. This should incidentally reduce the maintenance burden when upgrading between Django major versions. Testing:All places using the legacy base form should be reviewed with this change using both ASCII strings and Unicode strings as inputs. Below is a list of endpoints to review
/webclient/login//webadmin/forgottenpassword//webadmin/myaccount//webadmin/experimenter/new/webadmin/experimenter/edit/{id}(includingChange User's Password)/webadmin/group/edit/{id}/webclient/search/