Closed will-moore closed 9 months ago
This pull request has been mentioned on Image.sc Forum. There might be relevant details there:
https://forum.image.sc/t/expansion-height-for-key-value-pairs/81548/2
A Scrollpane could be considered since the list could be long and it will push the entries out of the viewport
A Scrollpane has been considered (that's what we have now) but it has limitations.
I think it's OK to push the other tabs out of the viewport when you want to view the contents of Key-Value Pairs.
In the 2nd screenshot above, you get much more of what you want to see (KVPs) instead of Tables 1
, Tags 0
, Ratings 0
, Attachments 0
, Others 0
.
Looks good to me. I'd agree, it's better than the internal KVP scrollpane. If the KVP panel really is extremely long and you want to see the attachments, comments, etc you can simply collapse the KVP panel.
This is now deployed on idr-testing. cc @francesw @jrswedlow
lgtm on idr-testing
See https://forum.image.sc/t/expansion-height-for-key-value-pairs/81548
The removes the restriction on height of the Key-Value Pairs panel, allowing it to expand to show all its content.
Before: (e.g. https://idr.openmicroscopy.org/webclient/?show=image-1884807)
After: (e.g. https://merge-ci.openmicroscopy.org/web/webclient/?show=image-18188)
Also cleaned some commented/invalid CSS and removed an unnecessary element that causes a gap after the Comments pane (see Before screenshot above).