ome / omero-web

Django-based OMERO.web client
https://www.openmicroscopy.org/omero
16 stars 29 forks source link

Add attachment dialog not loading #499

Closed dominikl closed 7 months ago

dominikl commented 1 year ago

See https://forum.image.sc/t/unable-to-add-attachment-using-omero-web/84146/ . The number of available attachments for the logged in user is probably too long. Pagination required?

imagesc-bot commented 1 year ago

This issue has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/unable-to-add-attachment-using-omero-web/84146/20

will-moore commented 1 year ago

To try and reproduce locally, need lots of FileAnnotations... These don't need to be different OriginalFiles, so we can create lots by picking an existing OriginalFile and...

$ omero login

$ for i in {1..10000}; do omero obj new FileAnnotation file=OriginalFile:3070; done

Using session for will@localhost:4064. Idle timeout: 10 min. Current group: Swedlow Lab
FileAnnotation:2530
...
will-moore commented 1 year ago

I don't know how many FileAnnotations are needed to cause the exception reported above, but I think that the user in that case is not trying to pick from E.g. 10000 existing FileAnnotations, but is just trying to upload a NEW File.

It may be that if you've got enough FileAnnotations to trigger the Ice::MemoryLimitException then the web UI might also do a bad job (or fail) to display them so you can actually pick one. It would be a shame if this broke the "Upload File" functionality. So we should probably pick a number of FileAnnotations that we know works OK, and if the user has more than that, we say "additional files not loaded".

joshmoore commented 1 year ago

:+1: with incremental improvements being:

chris-allan commented 7 months ago

@knabar / @will-moore: Also close with #517 and the merge and release of #519 in 5.24.0?

will-moore commented 7 months ago

Yep - issue is fixed now, thx 👍