If OMERODIR is set but etc/grid is missing do not use ~/omero/config.xml

[manics]

If OMERODIR is set but etc/grid is missing do not use ~/omero/config.xml

Using

      - omero-py==5.6.dev2
      - omero-web==5.6.dev3

$ OMERODIR=/opt/omero/web/OMERO.web/ /opt/omero/web/venv3/bin/omero config get

/opt/omero/web/OMERO.web/etc/grid not found; using /opt/omero/web/omero/config.xml

This should be an error since OMERODIR is specified, otherwise there is likely to be a lot of confusion over which etc/grid file is used.

[manics]

Arguably failing to set OMERODIR when a config.xml is required should always be an error. This is likely to be a source of confusion for anyone manually setting up a decoupled server (and we can expect loads of forum posts in response):

• Someone may set OMERODIR for some commands but forget to set it for others
• If OMERODIR is not set etc/grid/config.xml is automatically created in ~ but other directories such as var aren't (in the case of OMERO.web it will try to create something like venv/lib64/var which may be owned by root, and in any case is clearly an inappropriate place).

Is there a use-case for requiring config.xml when not running a server (OMERO.server or OMERO.web)? Otherwise could we always return an error if OMERODIR isn't set?

[joshmoore]

I'm pretty sure that the ~/omero/config.xml functionality was never used. I do wonder if $PWD might be a useful default, but otherwise, :+1: (This is likely a PR against omero-py though)