search

ome / openmicroscopy

OME (Open Microscopy Environment) develops open-source software and data format standards for the storage and manipulation of biological light microscopy data. A joint project between universities, research establishments and industry in Europe and the USA, OME has over 20 active researchers with strong links to the microscopy community. Funded by private and public research grants, OME has been a major force on the international microscopy stage since 2000.
https://www.openmicroscopy.org/omero
GNU General Public License v2.0
200 stars 102 forks source link

remove slice2java #6325

Closed jburel closed 2 years ago

jburel commented 2 years ago

Remove slice2java. Check that the build is green

jburel commented 2 years ago

Since we are using only one ice version, that could be removed.

jburel commented 2 years ago

Back to green https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-server/1242/ with this PR included

sbesson commented 2 years ago

OMERO.script integration tests (Python + Java) have been failing for the last two days - see https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-test-integration/1137/. This is possibly related to these changes

jburel commented 2 years ago

https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-test-integration/1144/ is green with this PR included

sbesson commented 2 years ago

In general, :+1: for getting rid of the unnecessary slice2java dependency for building.

The biggest change looking at the nightly artifacts is the removal of the -ice36 suffix from omero.version and hence the OMERO.server artifact name.

This raises essentially the same question as in https://github.com/ome/openmicroscopy/pull/6318#issuecomment-1113366461. Do we have an authoritative list of all the downstream locations that would be impacted by the change and will need to be reviewed? And do you have a feeling of the cost/time of updating these post server release?

joshmoore commented 2 years ago

Briefly:

jburel commented 2 years ago
jburel commented 2 years ago

@joshmoore I think we can also drop slice2py to build I have run ./build.py clean && ./build.py in a conda environment without slice2py and it works fine. The question is: do we want to have env to build only and env to run only?

jburel commented 2 years ago

The last 2 commits remove:

the build remains green