search

ome / openmicroscopy

OME (Open Microscopy Environment) develops open-source software and data format standards for the storage and manipulation of biological light microscopy data. A joint project between universities, research establishments and industry in Europe and the USA, OME has over 20 active researchers with strong links to the microscopy community. Funded by private and public research grants, OME has been a major force on the international microscopy stage since 2000.
https://www.openmicroscopy.org/omero
GNU General Public License v2.0
200 stars 102 forks source link

Add int test for getOriginalMetadata method #6361

Closed dominikl closed 1 year ago

dominikl commented 1 year ago

Add integration test for https://github.com/ome/omero-gateway-java/pull/72 . Simply checks if the method returns something.

jburel commented 1 year ago

Build failure https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-build/306/

dominikl commented 1 year ago

Sorry. Should be fixed now. How could the previous commit get a green tick, if it's already a compile error?

jburel commented 1 year ago

We will need to check, one job might exclude the tests?

dominikl commented 1 year ago

Closing again. Don't know how to test. I guess the artifical test images created for the integration test don't have any "original metadata", hence the method returns just an empty string for them.

sbesson commented 1 year ago

If the images created for the integration tests use the API to create the objects and then write the planes using the PixelsService, then there will indeed be no original metadata.

To test this API, you'll likely need to import an image. You should be able to use the .fake format which allows to create original metadata key/value pairs programmatically for testing - https://bio-formats.readthedocs.io/en/stable/developers/generating-test-images.html