ome / openmicroscopy

OME (Open Microscopy Environment) develops open-source software and data format standards for the storage and manipulation of biological light microscopy data. A joint project between universities, research establishments and industry in Europe and the USA, OME has over 20 active researchers with strong links to the microscopy community. Funded by private and public research grants, OME has been a major force on the international microscopy stage since 2000.
https://www.openmicroscopy.org/omero
GNU General Public License v2.0
200 stars 102 forks source link

tmp #6382

Closed jburel closed 7 months ago

jburel commented 7 months ago

Replace omero-scripts to omero_scripts so other components can be tested

sbesson commented 7 months ago

Definitely related to the changes in https://setuptools.pypa.io/en/latest/history.html#v69-3-0 to canonicalizing the package name in source distribution. As shown by the failure, this causes problem with the latest release of omero-scripts (https://pypi.org/project/omero-scripts/5.8.0/#files) which still uses the previous form for the package name.

Capping setuptools does not feel like a reliable solution as the next release of omero-scripts will most likely use the new naming scheme.

jburel commented 7 months ago

The same applies to all our Python packages The only one not affected is omero_marshal. Name has always been like that

We can

sbesson commented 7 months ago

We can

  • either rename all the package and release a new version
  • or add a pyproject.toml

Let's discuss options tomorrow. At least from my side, capping setuptools by whatever mechanism can only be considered as a short term fix.

The same applies to all our Python packages

But within the context of this repository, the only Python artifact downloaded and extracted via filename is omero-scripts, no? I understand there is are wider implications for the rest of the OME CI infrastructure. However looking at https://github.com/ome/devspace/blob/e91bc0e1420da617f05eb93d827af00e60bfe663/home/jobs/OMERO-server/config.xml#L140-L142, the usage of wildcards might make the logic more robust to the latest setuptools (breaking) changes.

jburel commented 7 months ago

It is. I was thinking of a wider fix