ome / prod-playbooks

Playbooks used by the OME team for deploying production services including OMERO
https://www.openmicroscopy.org/omero
BSD 2-Clause "Simplified" License
4 stars 18 forks source link

add logic for nightly pg dumps #349

Closed pwalczysko closed 2 years ago

pwalczysko commented 2 years ago

cc @sbesson

deployed on ome-training-3

possibly there will be some DB to use tomorrow ?

cc @khaledk2

sbesson commented 2 years ago

Unfortunately the Molecule failure comes from the fact the base Docker image does not have cron installed. I think there are two options:

pwalczysko commented 2 years ago

@sbesson if the expectation of a successful DB dump creation o/n is still reasonable ?, then I would like to do the suggested changes possibly later, as need to prioritize the upcoming workshop

sbesson commented 2 years ago

@sbesson if the expectation of successful dump creation o/n is still reasonable ?, then I would like to do the suggested changes possibly later, as need to prioritize the upcoming workshop

No hurry from my side. My comment was primarily captured the next steps to get this build green out of my head. Assuming you deployed it onto one of the internal training servers (where cron should been installed), I would be inclined to give ourselves a week to confirm the logic works as expected including the weekly rotation of the dumps in all cases.

pwalczysko commented 2 years ago

@sbesson does this https://github.com/ome/prod-playbooks/pull/349/commits/118c1e52bf60f6950abb0e4b1dc09960a33571f1 make sense ? The question is more where to put it, and the place I chose was because I saw a similar install in that yml already.

pwalczysko commented 2 years ago

Deployed on all 4 servers successfully. Merging.