search

ome / prod-playbooks

Playbooks used by the OME team for deploying production services including OMERO
https://www.openmicroscopy.org/omero
BSD 2-Clause "Simplified" License
4 stars 18 forks source link

Fix email #374

Closed pwalczysko closed 1 year ago

pwalczysko commented 1 year ago

Following the discussion last week about the demo email, this is an attempt to

  1. remove typos introduced by formatting of the text inside YAML
  2. remove links as they are possibly catched by spam filters, leave just one non-clickable link to walkthrough without https beginning
  3. simplify the text

cc @jburel @sbesson

Note: This is done on top of https://github.com/ome/prod-playbooks/pull/373 in order not to downgrade by accident.

The new email body looks as follows: Screenshot 2023-09-06 at 13 06 44

pwalczysko commented 1 year ago

Deployed on demo successfully (thanks @sbesson ).

The new email looks like (suggestions welcome, cc @jburel - removed the links and simplified, of course have to leave the username and password though....) Screenshot 2023-09-06 at 13 06 44

pwalczysko commented 1 year ago

ditto https://github.com/ome/prod-playbooks/pull/373#issuecomment-1719448010

sbesson commented 1 year ago

Echoing my suspicion at https://github.com/ome/prod-playbooks/pull/373#issuecomment-1719460096:

pwalczysko commented 1 year ago

Any objections to merge ? This has been already deployed and shown to work on demo server. If not merged, the danger is that we revert to the broken email from before by mistake cc @jburel @sbesson