ome / scc

OME tools for managing the Git(Hub) workflow
https://pypi.org/project/scc/
GNU General Public License v2.0
0 stars 15 forks source link

Recursive merge bug fixes and improvements #235

Closed sbesson closed 6 years ago

sbesson commented 6 years ago

Tested in the context of the ansible-roles repository (see https://trello.com/c/ruRyhHyP/22-ansible-roles-testing), this PR contains a series of improvements to increase the scalability of scc merge for repositories with submodules.

With the systematic usage of integration branches separated by _ rather than /, the last commits means there should be no need for any manual action when new organizational repositories are created as scc merge --push --update-gitmodules should be self-sufficient.

Testing this PR:

Fixes #230

joshmoore commented 6 years ago

Could https://ci.openmicroscopy.org/view/Failing/job/SCC-merge/976/console be related?

self = <github.Requester.Requester instance at 0x17c3710>, status = 500
responseHeaders = {'access-control-allow-origin': '*', 'access-control-expose-headers': 'ETag, Link, Retry-After, X-GitHub-OTP, X-RateLi...Accepted-OAuth-Scopes, X-Poll-Interval', 'content-length': '109', 'content-security-policy': "default-src 'none'", ...}
output = {'documentation_url': 'https://developer.github.com/v3/pulls/#create-a-pull-request', 'message': 'Server Error'}

    def __check(self, status, responseHeaders, output):
        output = self.__structuredFromJson(output)
        if status >= 400:
>           raise self.__createException(status, responseHeaders, output)
E           GithubException: 500 {u'documentation_url': u'https://developer.github.com/v3/pulls/#create-a-pull-request', u'message': u'Server Error'}

(same in the last 2 runs) Did integration tests pass for you locally?

joshmoore commented 6 years ago

Sorry, looks like that was unrelated. See https://github.com/openmicroscopy/snoopys-sandbox/pull/32182 instead. https://ci.openmicroscopy.org/view/Failing/job/SCC-merge/978/ is now green. Re-including and re-executing.

joshmoore commented 6 years ago

New run failed again (This time no PRs are left open).

sbesson commented 6 years ago

Unexcluding as #238 might help stabilizing the integration tests. I will see how tests go over the week-end and relist for review on Monday

sbesson commented 6 years ago

See https://ci.openmicroscopy.org/job/SCC-merge/989/ and https://github.com/openmicroscopy/snoopycrimecop/pull/239#issuecomment-420404464

joshmoore commented 6 years ago

LGTM.