Move --repository-config to all commands acting on Git repositories

ome / scc

OME tools for managing the Git(Hub) workflow

https://pypi.org/project/scc/

GNU General Public License v2.0

0 stars 15 forks source link

Move --repository-config to all commands acting on Git repositories #244

Closed sbesson closed 5 years ago

sbesson commented 5 years ago

This change allows to use command like update-submodules with a YML configuration file. The use case is a job to update https://github.com/ome/bio-formats-build submodules since bioformats is on a different tracking branch.

Proposed tag: 0.11.0

sbesson commented 5 years ago

See https://github.com/ome/bio-formats-build/pull/26 for an example of automated PR opened consuming this change using https://github.com/ome/bio-formats-build/blob/master/scripts/repositories.yml

Also included 5593286 which is a breaking formatting change for the commit message (# are now rendered as - see PR above). When it comes to creating PRs using a single commit message, it prevents # being rendered as Markdown heading. If acceptable, I would propose to call this 0.11.0. Otherwise it should be possible to make the PullRequest string representation configurable.

joshmoore commented 5 years ago

:+1: the formatting of the opened PR. My only potential concern here would be that some of the other commands which have now inherited --repository-config won't be able to handle it. From my POV, that's something we can piece apart down the road. Cheers.

joshmoore commented 5 years ago

No objection to the version number. Leaving you to merge/tag/release.

sbesson commented 5 years ago

Cheers. Will tag and release (also including the Travis based PyPI deployment).