Futurize: Py2 and py3 compatibility

ome / scc

OME tools for managing the Git(Hub) workflow

https://pypi.org/project/scc/

GNU General Public License v2.0

0 stars 15 forks source link

Futurize: Py2 and py3 compatibility #249

Closed manics closed 5 years ago

manics commented 5 years ago

First commit is the result of futurize -w -n ., remaining commits are attempts to fix problems.

[x] Python 3 unit tests currently fail due to relying on mox which doesn't support Python 3: https://travis-ci.org/ome/snoopycrimecop/jobs/568804378

Integration tests:

[x] test_check_milestone.py
[x] test_check_prs.py
[x] test_config.py
[x] test_label.py
[x] test_merge.py
[x] test_rebase.py
[x] test_tag_release.py
[x] test_travis_merge.py
[x] test_update_submodules.py

manics commented 5 years ago

Looking further into this, switching to mock/unittest.Mock as recommended (https://pypi.org/project/mox/) is non trivial, though it should be easier once someone's converted one set of tests in this or another repo.

joshmoore commented 5 years ago

No objections. One question:

The following subcommands have been tested functionally with these changes included and showed no regression:

Tested with Python2, Python3, or both?

sbesson commented 5 years ago

Only Python 2 only, but I will get through a quick test in a Python 3 virtual environment before merging.