ome / scc

OME tools for managing the Git(Hub) workflow
https://pypi.org/project/scc/
GNU General Public License v2.0
0 stars 15 forks source link

Do not check status for private repositories #256

Closed sbesson closed 4 years ago

sbesson commented 5 years ago

In the case of mixed private/public repositories, we might still want to pass a single command which checks statuses on public repositories but ignores the status of privat repositorye.

Alternatively, we could refine the definition of the statuses to handle the private repositories case.

joshmoore commented 4 years ago

Without this PR:

scc merge -S success-only BRANCH
git show HEAD | grep Excluded | wc -l
       6

With this PR:

PYTHONPATH=/opt/scc/ python -m scc.main merge -S success-only BRANCH
git show HEAD | grep Excluded | wc -l
0

:+1:

sbesson commented 4 years ago

Thoughts about calling this 0.12.3 vs 0.13.0 ?

joshmoore commented 4 years ago

I'd be for 0.12.3