search

ome / scc

OME tools for managing the Git(Hub) workflow
https://pypi.org/project/scc/
GNU General Public License v2.0
0 stars 15 forks source link

RFE: add --ignore-status label/filter #261

Open manics opened 4 years ago

manics commented 4 years ago

Allow PRs to be included regardless of their travis status by adding a new label/filter.

sbesson commented 4 years ago

I would have expected scc merge -S none to work for this. Can you expand on the type of scenario that you are looking into?

manics commented 4 years ago

-S none will merge all PRs regardless of status, the idea here is to allow individual PRs to be whitelisted, for example so that multiple dependent PRs can be included in a daily merge-all-PRs build without having to add workarounds in each PR to get Travis to pass.

sbesson commented 4 years ago

Understood. For PR-specific behavior, some detection logic would need to be inserted before:

https://github.com/ome/scc/blob/81babbcbe8f63ef5c3f9a6ca5755afe32c73f794/scc/git.py#L988-L990

to compare the labels and/or using the PullRequest.parse() API if we want to allow the status to be ignored via description/comment:

https://github.com/ome/scc/blob/81babbcbe8f63ef5c3f9a6ca5755afe32c73f794/scc/git.py#L949-L951