ome / scc

OME tools for managing the Git(Hub) workflow
https://pypi.org/project/scc/
GNU General Public License v2.0
0 stars 15 forks source link

Fix GitHub exception constructor #270

Closed sbesson closed 3 years ago

sbesson commented 3 years ago

The latest release of PyGithub 1.55 changed the constructor of GithubException which is used for discriminating between the PyGithub and PyGithub3 libraries. The impact can be seen on https://merge-ci.openmicroscopy.org/jenkins/job/WEBSITE-push/316/console which was run quickly after the release but will affect all other push jobs.

This PR adjusts the check to use a simple import and catch and ImportError. This should make the library compatible with 1.55+ while keeping support for earlier versions.

The tests are adjusted to use the new constructor as per the expectation that the latest version of PyGithub will be used

Proposing for an emergency 0.15.2 release