search

ome / scc

OME tools for managing the Git(Hub) workflow
https://pypi.org/project/scc/
GNU General Public License v2.0
0 stars 15 forks source link

Use clone_url rather than git_url when adding remotes #278

Closed sbesson closed 2 years ago

sbesson commented 2 years ago

The unauthenticated git protocol on port 9418 is no longer supported by GitHub. See https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.

sbesson commented 2 years ago

See https://ci.openmicroscopy.org/view/Failing/job/DOCKER-merge/1707/ for an example of failing build

sbesson commented 2 years ago

After additional investigation, the job mentioned in https://github.com/ome/scc/pull/278#issuecomment-1009771421 was upgraded to create a local environment installing scc rather than relying on a shared virtual environment. This was sufficient to fix the job failures - see https://ci.openmicroscopy.org/job/DOCKER-merge/1708/.

This is due to https://github.com/ome/scc/pull/257 which makes use the repository GitHub Pull references directly for merging candidate PRs rather than fetching remotes. The fix proposed in this PR is still needed for merge workflow using tracking branches specified via command-line parameters where there is no GitHub Pull reference but in most of our usages it should not be needed.

sbesson commented 2 years ago

If no objection, proposing to get this in and remove argparse from the dependencies in setup.py in a quick patch release as I discovered the latter caused some idempotence failures in our Ansible stack