ome / scc

OME tools for managing the Git(Hub) workflow
https://pypi.org/project/scc/
GNU General Public License v2.0
0 stars 15 forks source link

Add new stage:draft key/value pair allowing to exclude draft PRs #279

Closed sbesson closed 1 year ago

sbesson commented 1 year ago

Fixes #262

This is a simple expansion of the key/value filter infrastructure that allow to test the draft attribute of a Pull Request and exclude it from the merge candidates. The default org set of filters is modified to exclude draft PRs by default.

For testing, first install this branch e.g. in a virtual environment

source venv/bin/activate
pip install -e .

Then run the command against a repository against which Pull Requests in a draft stage are opened e.g. https://github.com/ome/bioformats/pulls. The default set of filters should now exclude these PRs from the merge candidates and indicate the reason in the log output:

scc merge info --master # should filter out draft PRs
scc merge info --master -Dall # should include all PRs including draft PRs

Proposed tag: 0.19.0 given the breaking change

will-moore commented 1 year ago

I've not tested this, but it seems like a good feature (expected behaviour). 👍

sbesson commented 1 year ago

Agreed, though now I feel guilty we never went 1.0 ;)

Happy to call the next version 1.0.0 if it's preferable.