ome / scc

OME tools for managing the Git(Hub) workflow
https://pypi.org/project/scc/
GNU General Public License v2.0
0 stars 15 forks source link

set github_version #283

Closed jburel closed 1 year ago

jburel commented 1 year ago

The introduction of github_version like in https://github.com/ome/conda-bioformats2raw/blob/master/bioformats2raw/meta.yaml#L3 breaks the scheduled build preventing the automatic bump of version

sbesson commented 1 year ago

The last commit still fails with

(base) sbesson@Sebastiens-MacBook-Pro-2 conda-bioformats2raw % ../scc/venv/bin/scc bump-version-conda
Traceback (most recent call last):
  File "/Users/sbesson/Documents/GitHub/scc/scc/main.py", line 64, in entry_point
    main("scc", items=[
  File "/Users/sbesson/Documents/GitHub/scc/venv/lib/python3.9/site-packages/yaclifw/framework.py", line 188, in main
    ns.func(ns)
  File "/Users/sbesson/Documents/GitHub/scc/scc/git.py", line 4133, in __call__
    msg = self.update_data(".", jinja2, latest_tag, sha256,
  File "/Users/sbesson/Documents/GitHub/scc/scc/git.py", line 4280, in update_data
    if data["package"][self.KEY_GIT_VERSION] and \
  File "/Users/sbesson/Documents/GitHub/scc/venv/lib/python3.9/site-packages/ruamel/yaml/comments.py", line 927, in __getitem__
    return ordereddict.__getitem__(self, key)
KeyError: 'github_version'

for me

jburel commented 1 year ago

I will have a look at it later today

jburel commented 1 year ago

Problem should now be solved. Also note https://github.com/ome/conda-bioformats2raw/pull/17

jburel commented 1 year ago

This could be tested against https://github.com/ome/conda-bftools

jburel commented 1 year ago

no longer needed