search

omec-project / pfcpsim

PFCP client simulator used for UPF testing
18 stars 18 forks source link

Feat/urr #69

Closed ianchen0119 closed 3 months ago

ianchen0119 commented 3 months ago
ianchen0119 commented 3 months ago

Hi @gab-arrobo & @thakurajayL

Could you please help to review the PR? Thanks.

ianchen0119 commented 3 months ago

Hi @gab-arrobo

Do I need to do any enhancements for this PR? If yes, please let me know when you feel free.

Many thanks.

gab-arrobo commented 3 months ago

Hi @gab-arrobo

Do I need to do any enhancements for this PR? If yes, please let me know when you feel free.

Many thanks.

Hi @ianchen0119, I will try to review your PR in the coming days and will get back to you

gab-arrobo commented 3 months ago

@ianchen0119, I just enabled some additional linters. Please rebase your PR. Thank you!

ianchen0119 commented 3 months ago

@ianchen0119, how did you test the changes/PR?

Hi @gab-arrobo

After the UPF gets started, the fuzzing can be enabled. It will connect to the UPF and try to send the malformed PFCP message to explore the potential security issue.

We can use the command below to trigger the fuzzing, for example:

go test -fuzz=Fuzz -p 1 -parallel 1 -fuzztime 15m ./fuzz/...

Furthermore, go-upf PR #33 is to fix the bug, reported by a community user, and it can be reproduced by the fuzzing.

andy89923 commented 3 months ago

Hello,

I push a commit to let PFCP accept the loopback interface. Also, this PR was functional in my environment.

截圖 2024-03-27 下午2 37 38

I run the UPF in host (10.10.0169), and run PFCPSIM on the same machine. It can create sessions, delete sessions, and also receive reports from UPF.

ianchen0119 commented 3 months ago

Hi @gab-arrobo Could you please help to approve the CI workflow?

Thank you.

gab-arrobo commented 3 months ago

Hello,

I push a commit to let PFCP accept the loopback interface. Also, this PR was functional in my environment.

截圖 2024-03-27 下午2 37 38

I run the UPF in host (10.10.0169), and run PFCPSIM on the same machine. It can create sessions, delete sessions, and also receive reports from UPF.

Thanks for your input/update. I am going to try it.

andy89923 commented 3 months ago

Hello,

Thanks for the suggestion! @gab-arrobo

These were what I did in the latest commit: