search

omec-project / pfcpsim

PFCP client simulator used for UPF testing
20 stars 18 forks source link

Enable `revive` linter #89

Open gab-arrobo opened 4 months ago

gab-arrobo commented 4 months ago

With the goal of improving the code quality in this repo, it would be good to add the revive linter (as shown below) and properly add the documentation to the different functions

diff --git a/.golangci.yml b/.golangci.yml
index 357611a..4d11a06 100644
--- a/.golangci.yml
+++ b/.golangci.yml
@@ -239,6 +239,7 @@ linters:
     - typecheck
     # Additional
     # - lll
+    - revive
     - godox
     #- gomnd
     - goconst
gab-arrobo commented 4 months ago

@ianchen0119 are you or someone you know available to help address this issue?

ianchen0119 commented 4 months ago

Hi @gab-arrobo Would you happen to know if this task is urgent? if not, I can help.

gab-arrobo commented 4 months ago

Hi @gab-arrobo Would you happen to know if this task is urgent? if not, I can help.

Hi @ianchen0119, This is not an urgent task. Please feel free to work on it when you have a chance. After this is addressed, I can create a new tag/release for pfcpsim, Thanks!