search

omec-project / smf

10 stars 34 forks source link

chore: Simplifies CI workflows #201

Closed gruyaume closed 11 months ago

gruyaume commented 11 months ago

Description

This PR simplifies the Github Actions CI workflow by combining all jobs that should be run on master and on PR's to master in one file. The only real change in behavior is that we no longer update an existing PR with the outcome of a go fmt. Since we run go lint, the CI will simply fail if a given PR has bad formatting.

Effectively, this reduces the amount of CI lines of code by more than 50% without sacrificing anything.

Rationale

It was hard to wrap one's head around what jobs were done at which moment because of the various files, their different conditions and the amount of commented workflow line. While the file representation was hard to read, the actual workflow was quite simple: Run X, Y, Z jobs on push to master and PR's to master. This PR here reflects this.

onf-bot commented 11 months ago

Can one of the admins verify this patch?

onf-bot commented 11 months ago

Can one of the admins verify this patch?

gab-arrobo commented 11 months ago

ok to test