Closed patriciareinoso closed 3 weeks ago
@gab-arrobo @thakurajayL can you take a look?
@patriciareinoso can you please ask one of your colleagues to give a first review? I am currently pretty busy with other stuff and if one of your colleagues reviews it, I can give it a "light" review, ok? :-)
Shall review changes in a day or 2 .
Could you please raise PR for config in the default helm chart? with default config option. It will help in making sure feature is known to community.
Could you please add a details in readme file as well. This will help community users whoever wants to enable & use this feature. Whatever details you have provided in the PR can be used in the readme. thanks.
The PR description says that password is not required during account creation. However, implementation requires password for account creation.
@thakurajayL @gab-arrobo this PR is ready for review again
@patriciareinoso, if you need to create a release, feel free to make a change in the VERSION
file as part of this PR, or you can open another PR for that.
@patriciareinoso, if you need to create a release, feel free to make a change in the
VERSION
file as part of this PR, or you can open another PR for that.
@patriciareinoso let's add the version change part of this PR please. I'll be discussing this change Tomorrow and it would be awesome if it was merged at that point.
@patriciareinoso, if you need to create a release, feel free to make a change in the
VERSION
file as part of this PR, or you can open another PR for that.@patriciareinoso let's add the version change part of this PR please. I'll be discussing this change Tomorrow and it would be awesome if it was merged at that point.
@gruyaume she is off today. After merging this, we need to create a new PR.
After merging this, we need to create a new PR.
I didn't know she was off, my bad.
Why create a separate PR for the version change? Let's wait for her to come back and do add the requested copyright changes and add the version file.
21 Eki 2024 Pzt, saat 16:08 tarihinde Guillaume Belanger < @.***> şunu yazdı:
After merging this, we need to create a new PR.
I didn't know she was off, my bad.
Why create a separate PR for the version change? Let's wait for her to come back and do add the requested copyright changes and add the version file.
Of course we do not need a new PR, if we wait for her.
— Reply to this email directly, view it on GitHub https://github.com/omec-project/webconsole/pull/217#issuecomment-2426629979, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFLNJJO5L3MLORWVK6CDRRTZ4T4C7AVCNFSM6AAAAABOBDNV4WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRWGYZDSOJXHE . You are receiving this because you commented.Message ID: @.***>
Description
Rationale
Webui is the upstream component offering an API to configure the 5G core network in SD-Core. However, Webui does not support any authentication mechanism which makes it accessible to everyone, threatening the product security.
The PR
This PR also:
username
on the useraccount collection to avoid duplicationEnableAuthentication
parameter is enabled, the DB information is also set on the config fileconfigapi/api_inventory.go
ToBsonM
andMapToByte
to avoid duplicationThe Feature
The following endpoints were added:
GET /config/v1/account
POST /config/v1/account
GET /config/v1/account/:username
DELETE /config/v1/account/:username
POST /config/v1/account/{username}/change_password
POST /login
GET /status
There are 2 types of users (roles):
AdminRole
andUserRole
. Authorization is implemented based on these 2 roles.UserRole
user can: GET their own account, change their own password.AdminRole
user can perform any action over any endpoint, over their own user or any other user.The
AdminRole
user cannot be deleted.Usage
To enable this feature, add the following to the config file.
In order to perform any operation over the webui, the user must have logged in. The creation of the first user does not need authentication. The first user will has
AdminRole
user by default.Create User
Log in
This operation returns a
token
that must be used on the following requests.Get Users
Get User
Change Password
Delete User
Get Status
This operation does not need token, it indicates whether the first user was successfully created.
or