search

omecra / de.omecra.oedt.updatesite

OEDT Plug-in Updatesite - Issue Repository for OEDT
12 stars 0 forks source link

Occurrence marker and rename - occurrence not marked/replaced #163

Closed lievendf closed 1 year ago

lievendf commented 1 year ago

Hi,

I found a bug where the 'rename' functionality failed to see and rename an occurrence.

afbeelding afbeelding afbeelding

In our code there happened to be a class variable with the same name, so this code kept compiling so we introduced a bug...

CLASS OEDTRenameIssue.OEDTRenameIssue:

    DEFINE PUBLIC PROPERTY ProcedureHandle AS HANDLE NO-UNDO
    GET.
    PRIVATE SET.

    CONSTRUCTOR PUBLIC OEDTRenameIssue(ProcedureHandleInput AS HANDLE):

        RUN Dummy IN ProcedureHandleInput("x":U).
        RUN Dummy2 IN ProcedureHandleInput.

        Dummy3(ProcedureHandleInput).

    END CONSTRUCTOR.

    METHOD PRIVATE VOID Dummy3(ProcedureHandleInput AS HANDLE):

        ASSIGN ProcedureHandle = ProcedureHandleInput.

    END METHOD.

END CLASS.
lievendf commented 1 year ago

It looks like the occurrence that isn't detected is seen as a method call. If I create a new method "ProcedureHandleInput" then the occurrence marker marks it when selecting ProcedureHandleInput in the RUN Dummy statement...

lneumeier commented 1 year ago

Yes, that's the issue. I look into it.

lneumeier commented 1 year ago

Fixed with OEDT 9.4.8.