search

omega8cc / boa

Barracuda Octopus Aegir 5.5.0-PRO
https://omega8.cc/compare
394 stars 75 forks source link

[docs] D8 platform install verifies at platform root instead of index.php level #1422

Open pricejn2 opened 5 years ago

pricejn2 commented 5 years ago

Debian 9 BOA 4.0.2-dev

By accident, I installed a new D8 platform at a publish_path of platform-name instead of platform-name/docroot and it verified successfully (in contradiction to https://github.com/omega8cc/boa/blob/master/docs/COMPOSER.txt#L33). Tested a new site install with no problem, but of course daily.sh identified the platform and all sites as ghosts given that index.php is not present at the platform-name level (https://github.com/omega8cc/boa/blob/master/aegir/tools/system/daily.sh#L1915).

I'm guessing this is a feature of Drush 9 that detects a valid D8 installation at the platform root instead of the requisite index.php level of prior Drush versions.

omega8cc commented 5 years ago

It's not Drush 9 which is not used in Aegir by the way, it's our experimental patch in our Provision fork in action -- we are trying to automate this detection: https://github.com/omega8cc/provision/commit/71cd2926fd30454740ab80a1523c4c77bbc4335e

omega8cc commented 5 years ago

https://github.com/omega8cc/provision/commit/310ab494abf7550693d06a56eaed23f8e9a8bf33 https://github.com/omega8cc/provision/commit/7b2441d4c5d494916f6ebf15050827d3b6130e30 https://github.com/omega8cc/provision/commit/a725ec40a1d3188bcdca9a9e03522eb6a8d591ac

pricejn2 commented 5 years ago

I see. Thanks for clarifying and pointing me to the specific provision commits.

Feel free to close this ticket. Was more of an FYI in case someone installs a D8 platform using a publish_path of platform-name instead of index.php level directory, the platform and all sites will get treated as ghost installations.