omegazeng / run-mariabackup

Script to create full/incremental backups with mariabackup. Compress with xbstream.
MIT License
121 stars 73 forks source link

What are differences to jmfederico / run-xtrabackup.sh? #5

Open cmonty14 opened 4 years ago

cmonty14 commented 4 years ago

Hi, you forked this backup script from jmfederico / run-xtrabackup.sh.

Question: Is your script function wise identical to the original script?

THX

omegazeng commented 4 years ago

basically the same. I want to find an easy way to backup databases then I get jmfederico/run-xtrabackup.sh.

mariabackup is a little different from xtrabackup. at first, I change the script for self-use. Just add some documents and put it on Github.

THX

mhaamann commented 3 years ago

One big difference is the checks on line 105

Just learned by coincidence that this script does not exit with an error if the mariabackup cli fails, so be carefull with running this via cron unattended. Didn't loose any data but spotted this in a routine checkup of our cron jobs.

cantoute commented 3 years ago

Thanks for sharing this. To be honest I have given up using this script because it freezes the db during backups even for read access. Finally mysqldump seems more reliable and don't lock tables on read. Takes a bit more disk space, but reliable is what we want.

Le 19 mars 2021 11:11:56 GMT-04:00, Matthias Haamann @.***> a écrit :

One big difference is the checks on line 105

Just learned by coincidence that this script does not exit with an error if the mariabackup cli fails, so be carefull with running this via cron unattended. Didn't loose any data but spotted this in a routine checkup of our cron jobs.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/omegazeng/run-mariabackup/issues/5#issuecomment-802904384

-- Antony Gibbs @.*** +591.7227.5988 +33 (0)9 72 11 71 25 +598 (0)9 9360 744

omegazeng commented 3 years ago

Thanks for sharing this. To be honest I have given up using this script because it freezes the db during backups even for read access. Finally mysqldump seems more reliable and don't lock tables on read. Takes a bit more disk space, but reliable is what we want. Le 19 mars 2021 11:11:56 GMT-04:00, Matthias Haamann @.> a écrit : One big difference is the checks on line 105 Just learned by coincidence that this script does not exit with an error if the mariabackup cli fails, so be carefull with running this via cron unattended. Didn't loose any data but spotted this in a routine checkup of our cron jobs. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #5 (comment) -- Antony Gibbs @. +591.7227.5988 +33 (0)9 72 11 71 25 +598 (0)9 9360 744

make sure you are using InnoDB table.

https://www.percona.com/doc/percona-xtrabackup/LATEST/how_xtrabackup_works.html Locking is only done for MyISAM and other non-InnoDB tables after Percona XtraBackup finishes backing up all InnoDB/XtraDB data and logs.