search

omeka-s-modules / Collecting

GNU General Public License v3.0
2 stars 6 forks source link

Collecting forms not visible to Editors #35

Closed patrickmj closed 6 years ago

patrickmj commented 6 years ago

On the admin side for a site as an Editor, I see the link to the Collecting forms page, but forms do not show up. There's also no button to add a new form.

I'm not sure what the intended permissions through all the roles and options should be.

jimsafley commented 6 years ago

Yes, currently only site admins can create and delete collecting forms. I remember my logic as being "if a user can't delete a form they shouldn't be able to create one." My assumption is that form creation and deletion is not an editorial purview, but an administrative one. Editors can update forms and add forms to site pages.

patrickmj commented 6 years ago

Thanks. Weirdly, yesterday the form created wasn't showing up for editors, but today it is (some kind of caching thing?). Editor cannot update the form, though.

jimsafley commented 6 years ago

I just updated an existing form as a site editor. Were you talking about global roles? I'm talking about site roles.

patrickmj commented 6 years ago

Ah, yes. Sorry. Was talking about global role of editor. That user isn't added to the site. So is the idea that global editor can look through everything, but needs to be added to the site to be able to edit?

patrickmj commented 6 years ago

Part of my confusion was that the site was created by that user with global editor role, but being the owner didn't give all those permissions. So, this might be a core issue.

jimsafley commented 6 years ago

Yes, perhaps users that create sites should automatically be added as the site admin, regardless their global role.