search

omeka-s-modules / Collecting

GNU General Public License v3.0
2 stars 6 forks source link

Feature/clean #47

Closed Daniel-KM closed 3 years ago

Daniel-KM commented 5 years ago

Before new features, I prefered to do some cleaning of the code.

jimsafley commented 4 years ago

Apologies for the late reply but I'm not going to merge this PR or PRs that are based on it: #48, #49, #50, #51, #52, #54, #56. I would be more willing to accept this PR if it had focused exclusively on coding standards, but on a scan I see additions of preferential code and what appears to be a new feature (843a1d952961eb55ea24ca686d8fe852260af17f). While the features introduced by the other PRs are worth consideration, there's too much divergence in this PR to justify a thorough review.

Daniel-KM commented 3 years ago

Ok for removing pull requests. it's hard to manage after two years, since I developed the module Contribute, that does the same thing, except that forms are standard resource templates, so a lot easier to manage for admins. And it can manage corrections of metadata of items too.