omeka-s-modules / Collecting

GNU General Public License v3.0
2 stars 6 forks source link

Improvements to terms of service #67

Closed jimsafley closed 3 years ago

jimsafley commented 4 years ago

See this forum post.

There is interest in changing the terms of service (TOS) from a plain text to a HTML field. I forget why we decided to make TOS plain text, but it seems like a good idea. One reservation is how it would change existing TOS's that were written using unformatted text and new lines.

We'd do this by adding CKEditor JS to the site admin template:

CKEDITOR.inline(document.getElementById(collecting_tos'));

And changing the Content-Type in IndexController::tosAction():

$response->getHeaders()->addHeaderLine('Content-Type', 'text/html; charset=utf-8');
jimsafley commented 4 years ago

Actually, the specific request is not to make the TOS a HTML field, but to have an option to change the TOS URL itself. This should be possible by adding a "Terms of service URL" field to site settings, and using that on the collecting form. I prefer this solution over the one above.

jimsafley commented 3 years ago

Fixed in c5edc9bf97f353a261c2511900c3c37334691aea