omeka-s-modules / Datavis

GNU General Public License v3.0
2 stars 1 forks source link

Text overflow in bar chart #17

Open allanaaa opened 8 months ago

allanaaa commented 8 months ago

With dimensions (e.g. 700x700) required in the settings, there should be no overflow from that - everything should be contained within. I'm getting text labels overflowing to the left of those dimensions instead of wrapping. In Thanks Roy and in Default:

Screenshot 2023-12-21 at 11 57 41 Screenshot 2023-12-21 at 12 03 59 Screenshot 2023-12-21 at 12 01 45
jimsafley commented 8 months ago

The diagram is separate from the flow of the surrounding markup, so wrapping here is not possible. Docs should mention this and recommend that margins should be adjusted to accommodate long labels. Also, I believe labels have a title attribute that shows the entire label during hover.

allanaaa commented 8 months ago

There has got to be a way to do this out of the box.

Also, the interface should describe what the margins do in this case (i.e. contain the text labels, sit within the total dimensions, and reduce the size of the graphic when making space for the text). This is not a standard use of the CSS concept of "margin" so people should rightly be confused.

jimsafley commented 8 months ago

It's the standard use of the diagram concept of "margin," but I see your point. And perhaps there's a way to wrap, but I'm not going to address it any time soon.

allanaaa commented 7 months ago

Similarly, the pie chart labels are being generated (I assume) somewhere in the middle of each slice, so they overlap frequently. Any chance of being sure they don't all display in the same coordinates?

Screenshot 2024-01-30 at 17 52 18