search

omeka-s-modules / Datavis

GNU General Public License v3.0
2 stars 1 forks source link

Diagram page titles not showing in title attribute #18

Closed allanaaa closed 10 months ago

allanaaa commented 11 months ago

I'm not getting my diagram/page titles on their pages, only "site title - installation title".

Screenshot 2024-01-03 at 11 49 55

I know they're meant to be dropped in as page blocks, but since we do offer a public URL for each a page title would be nice.

jimsafley commented 10 months ago

These diagrams are not in a page context, so there's no page title to display.

allanaaa commented 10 months ago

Since we offer people the direct URLs they will at some point want to use them as standalone pages. They would be good as browse pages, using the description field you provide to give some instructions.

I would say, either don't give them public pages, or give them public pages properly, with titles.

jimsafley commented 10 months ago

I've added a "Data visualization" custom link to site navigation.

allanaaa commented 10 months ago

Can we also add the page title into the title attribute?

jimsafley commented 10 months ago

I pushed a change that adds the page title.