omeka-s-modules / Datavis

GNU General Public License v3.0
2 stars 1 forks source link

Testing: Group by property value for item relationships dataset #20

Closed jimsafley closed 8 months ago

jimsafley commented 9 months ago

Users can now group by "Property value" when generating an "Item relationships" dataset. The existing "Group by" element now has a "Property value" option that opens a property select menu. After selecting a property and generating the dataset, the resulting diagram will include nodes that are grouped (colored) by unique values of the selected property. For example, choosing foaf:gender could group nodes by "male" and "female."

allanaaa commented 9 months ago

All of these people have clean "gender" data, but only two of them are reading "male" correctly:

Screenshot 2024-01-04 at 17 55 06 Screenshot 2024-01-04 at 17 55 10

None of the blue are reading as "female", just some sort of default group for the rest. Dataset is loading as "null" and "null": http://6floors.org/workspace/omeka-s/s/bigdata/data-visualization/dataset/12?pretty_print=1

While it's colouring the group it identified, it's not sorting by it when told to:

Screenshot 2024-01-04 at 17 58 58
jimsafley commented 9 months ago

Sorry, I should have mentioned that you need to re-generate the dataset.

allanaaa commented 9 months ago

I did, a few times. I can start with a fresh one though.

allanaaa commented 9 months ago

Nope, same dataset as the earlier one.

jimsafley commented 9 months ago

The most recent commit should work.

allanaaa commented 9 months ago

Same thing - it's identifying two people as male, and the rest as "null" (but the grouping is reversed now).

http://6floors.org/workspace/omeka-s/s/bigdata/data-visualization/diagram/12 http://6floors.org/workspace/omeka-s/s/bigdata/data-visualization/dataset/12?pretty_print=1

jimsafley commented 9 months ago

Try the newest changes.

allanaaa commented 8 months ago

That's working great now.

If you choose to group by a linked resource (something like Location, which Sharon has as linked items) then you see an admin/edit link in the popup, rather than the linked item's title.

http://6floors.org/workspace/omeka-s/s/bigdata/data-visualization/diagram/12

Screenshot 2024-01-08 at 11 57 01

Also, I wonder if we can include something in the admin interface, like "If you make changes above this line, you will need to re-generate the dataset before you will see an updated visualization." Which would include the search query and the dataset configuration sections. Or we can move the search query to the next section.

jimsafley commented 8 months ago

If you choose to group by a linked resource (something like Location, which Sharon has as linked items) then you see an admin/edit link in the popup, rather than the linked item's title.

I made a change that should fix this.

allanaaa commented 8 months ago

Thanks, I'm happy with this!

I will put in the docs that people need to look at the dataset to be sure of what they're seeing, and that hard-refreshing really helps. :)

Just to be sure - when you're grouping, will all the null values always come in the first group? This seems to be the case, but I want to be sure before I put it in the docs.

jimsafley commented 8 months ago

Yes, null values will come first, which is usual for database sorting.