omeka-s-modules / FileSideload

GNU General Public License v3.0
2 stars 3 forks source link

Testing: Recursive sideload #20

Closed jimsafley closed 2 years ago

jimsafley commented 3 years ago

The master branch introduces a feature that allows users to sideload recursively from a directory. Test this by adding a directory hierarchy within your configured sideload directory and filling those subdirectories with files. Then, add a "Sideload" media to an item and check if you can see and upload files from the directory hierarchy you've just created.

mebrett commented 3 years ago

Does it matter which branch of Omeka S I'm on for this?

mebrett commented 3 years ago

I made a few very nested directories, and was able to add image files from them. I'll try again in a moment with audio and video files, just to be sure. One question - if I don't give the files new titles, the automatic titles include the filepath, as in this image:

Screen Shot 2020-09-01 at 11 06 58 AM

Is there any way in which the path in the name might cause a problem? (not with usability but with technical functions)

jimsafley commented 3 years ago

Good question, but I don't believe there's any technical problems to the inclusion of slashes there.

mebrett commented 3 years ago

Works with audio and video as well. I did notice that the dropdown seems to have a length limit which removed the name of a file:

Screen Shot 2020-09-01 at 11 30 57 AM

If selected you see that this is actually

Screen Shot 2020-09-01 at 11 31 01 AM

The full file name is very 19th c: The_imperial_gazetteer_of_Scotland;_or,_Dictionary_of_Scottish_topography,_compiled_from_the_most_recent_authorities,_and_forming_a_complete_body_of_Scottish_geography,_physical,_statistical,_and_(14595783190).jpg

jimsafley commented 3 years ago

I can't reproduce this, even when using the same filename. On what browser are you seeing this?

mebrett commented 3 years ago

Chrome Version 84.0.4147.135 (Official Build) (64-bit Let me re-upload the file and see if changing the window size helps.

mebrett commented 3 years ago

Tried in Firefox and did not have the same issue. I wonder if it's something to do with the ; and , in the file name?

Daniel-KM commented 2 years ago

The pr #25 allows to import a whole directory directly.