omeka-s-modules / FileSideload

GNU General Public License v3.0
2 stars 3 forks source link

Feature/ingest folder #25

Closed Daniel-KM closed 2 years ago

Daniel-KM commented 2 years ago

Sometime users want to import some hundreds files for one item, for example all images of a scanned manuscript, so to select the directory is a lot simpler.

Daniel-KM commented 2 years ago

The pr is based on previous one because it fixes the same issue, but it can be separated if needed.

AlyxTaj commented 2 years ago

The people who create items one by one at our library are not usually very tech savy. On Omeka Classic, they used to select all the documents from one repertory to upload them and that was it. This was essential when dealing with documents of hundreds of pages. Now that we're moving to Omeka S, the bulk upload of files is going to be missing, and I cannot imagine them creating a CSV file with the list of media to link to an item they have created. This folder based option to FileUpload would be an amazing improvement for us.

jimsafley commented 2 years ago

I'm currently reviewing this. Please rebase your branch so the changes I merged upstream are updated and don't show up in this PR.

Daniel-KM commented 2 years ago

Yes, it's rebased.

jimsafley commented 2 years ago

I'm wary of the use of "folder" throughout your changes (even the new name). We already use "directory" in this module and others, so I prefer that you change "folder" to "directory."

Daniel-KM commented 2 years ago

I renamed "folder" by "directory" in last commit.

jimsafley commented 2 years ago

I notice that the "Directory" select menu does not include the sideload directory itself. Is there a reason for this?

jimsafley commented 2 years ago

Thank you for this important feature!