search

omeka-s-modules / FileSideload

GNU General Public License v3.0
2 stars 3 forks source link

Allowed absolute paths inside the main directory. #7

Closed Daniel-KM closed 6 years ago

Daniel-KM commented 7 years ago

This allows to create csv files totally independantly from Omeka and to import local files, as long as they belong to the main dir as defined in FileSideload.

zerocrates commented 7 years ago

What's the benefit of doing them as absolute paths? It seems to me like it doesn't really let you do anything you can't do with the relative-only version we've got now, if you're going to maintain the restriction that the files have to be within the sideload directory anyway.

Daniel-KM commented 7 years ago

The main advantage is that the filepaths to import via Csv Import can be absolute, not only relative. So it is more flexible. For example, it's simpler to modify the sideload path if needed than all rows in a csv file. Besides, of course, for security, the check must be kept.

Daniel-KM commented 6 years ago

I rebased it on the last version.