omeka-s-modules / Hierarchy

GNU General Public License v3.0
0 stars 1 forks source link

Empty grouping labels should provide a fallback #2

Closed kimisgold closed 1 month ago

kimisgold commented 1 month ago

I was testing to see what would happen if I left a number of the label fields empty, and the result is that a grouping can appear with a blank title in both the Hierarchy block and the main heading in the public view. I would expect the fallback to be the item set name, or "[Untitled]".

Here's the setup within Hierarchy.

image

Here's the grouping with an empty title.

image

Here's the empty title in the public view.

image

(#1)

matthewjmckinley commented 1 month ago

You're right, that could be more elegant. A Hierarchy can't really fall back on an item set, since those are assigned at the Grouping level under the Hierarchy, but I can have them show as [untitled] when nothing is there.

matthewjmckinley commented 1 month ago

Fixed in https://github.com/omeka-s-modules/Hierarchy/commit/aa552652f4d468c2eb42f8c1273a5c705eb974fd