omeka-s-modules / Scripto

Transcribe and translate items
GNU General Public License v3.0
7 stars 8 forks source link

Add layout, zoom, and rotate controls to media/show. #8

Closed kimisgold closed 6 years ago

jimsafley commented 6 years ago

Ubuntu 16.04 | Google Chrome 65.0.3325.181

kimisgold commented 6 years ago

@jimsafley I think I've addressed most of your comments, with the exception of the review controls as buttons instead of checkboxes—still chewing on that, as I don't believe that buttons would be faster (since the labels activate the checkboxes as well), but it seems less essential for the moment.

jimsafley commented 6 years ago

A few things that still need addressing:

kimisgold commented 6 years ago

The latest commits should address your most recent points.

jimsafley commented 6 years ago

Thanks for the fixes. They look good.

About the media review form: I don't feel that "Approval status" or "Completion status" followed by a checkbox is very clear to the reviewer. Forget my earlier suggestion of a button. Fundamentally I feel that a) the current status should be abundantly clear at a glance, and b) that the toggle between statuses should be equally clear and quickly toggled. I'm going to merge this PR, but let's iterate through some ideas (with @mebrett's and @alyssafahringer's help) about how to best present the review form.

By the way, I'll eventually have more additions to the review form, so there's a need to further streamline and conserve space.