search

omeka-s-modules / Sharing

Omeka S module for sharing content via 1) Social Media and 2) Embedding Omeka S content in other sites
GNU General Public License v3.0
4 stars 6 forks source link

Decide between rolling our own buttons or taking what services give us #15

Closed patrickmj closed 8 years ago

patrickmj commented 8 years ago

In #6 I was working from the assumption that we'd make our own, using font-awesome as we have elsewhere. After digging into all the details, I'm wondering whether we should just take what's given by each service.

On the pro side for making our own, it would help make the look of a site more consistent. We'd also be able to design all the buttons to be consistent with each other, for things like height and width and how they'll stack together. In the case of Tumblr at least, it would also reduce the JS overhead. However, we would have to write varying amounts of our own JS for each one, but not too much. We'd also be constrained in our design to follow their branding requirements -- probably a good idea anyway, but something for us to do.

If we just took what they give us, we'd have some options for customizing them, but mostly we'd take what they give us. More of the JS would just be supplied by them, too, and we wouldn't need to worry about their branding rules.

Any thoughts @kimisgold @zerocrates @jimsafley @kalbers ?

patrickmj commented 8 years ago

no strong feelings, so going with the provided buttons