Testing new event options

patrickmj commented 7 years ago

Sharing now has an option under site settings to choose whether to show the sharing buttons at the top or the bottoms of the pages where it works. This should be looked at across all the themes to see if they show up okay with both options (and that the sharing still works to the various sites, though a doubt there's been changes there).

Sharing -- latest master branch Themes -- I think all of those are for latest master S Core -- latest develop

mebrett commented 7 years ago

Are there any specific expected behaviors or anticipated bugs you want us to look for?

patrickmj commented 7 years ago

Not really...basically just whether the buttons show up reasonably in the themes, wherever they are placed (the top option and event is new). And whether anything broke.

mebrett commented 7 years ago

And just to double-check: sharing buttons should show up on all pages, not just item-show ones

patrickmj commented 7 years ago

Right now, it should be pages, item-show, and browse pages. If they make sense to have elsewhere but aren't there, those make sense as new issues.

jannellelegg commented 7 years ago

Testing with the default theme, top and bottom:

Top:

they are appearing at the top of each page and sharing works.
some alignment issues on pages - gap at the top/left perhaps because of the search bar?
Alignment works better on subpages- still a gap on the left.
Icons are also awkwardly spaced on item pages:

Bottom:

they are appearing at the bottom of each page and sharing works.
alignment is also slightly indented from the left:

page/subpage: default-bottom

item page: default-bottom2

patrickmj commented 7 years ago

Pushed up a CSS change to master branch that should resolve the spacing issues. It's worth looking at across browsers to make sure that there isn't a browser quirk.

patrickmj commented 7 years ago

Pinging @mebrett @jannellelegg @alyssafahringer on whether the fixes on master resolve the above issues.

jannellelegg commented 7 years ago

Testing with default theme, top and bottom.

Top: buttons worked across all browsers and buttons populated across all browsers

Left alignment issue seems to be specific to Chrome: 2 default top chrome

Safari: 2 default top safari

Firefox: 2 default top firefox

Bottom: buttons worked across all browsers and buttons populated across all browsers

Left alignment issue, again, seems to be specific to Chrome: 2 default bottom chrome

Safari: 2 default bottom safari

Firefox: 2 default bottom firefox

jannellelegg commented 7 years ago

Other themes:

CenterRow:

issue with alignment exists on Chrome (top/bottom)

centerrow top chrome centerrow bottom chrome

Item page is not populating the share buttons (in Chrome, Safari, Firefox) when it is set to top.
alignment is a bit awkward on the item pages when set to bottom. It's not aligning with the text or centering as the other items do on the page.

Chrome: centerrow bottom chrome item Firefox: centerrow bottom firefox item Safari: centerrow bottom safari item

jannellelegg commented 7 years ago

The Daily:

issue with alignment exists on Chrome (top/bottom):

Bottom item page: the daily bottom chrome item

In firefox and safari, buttons are populating appropriately - no alignment issues.

jannellelegg commented 7 years ago

Cozy:

similar to the other themes, in Chrome there is an indention from the left on when set to top or bottom:
On the item page, in Chrome (not in Safari or Firefox), the buttons overlap with text on the page:

zerocrates commented 7 years ago

Is there a link to this site?

I can't seem to reproduce the left alignment issue.

mebrett commented 7 years ago

http://dev.omeka.org/mebrett/testomekas/s/FlicksOfThe80s/page/home

kimisgold commented 7 years ago

Even looking at that link, I don't see the left alignment from the screenshots using Cozy on Chrome.

mebrett commented 7 years ago

I'm not seeing the alignment issues in Chrome, but will second the issue on Center Row where sharing buttons are not showing up on item pages.

ex http://dev.omeka.org/mebrett/testomekas/s/austen/item/3493

mebrett commented 7 years ago

Alignment issue that Jannelle experienced was probably caused by an adblocking plugin for Chrome. Ad Blockers tend to interfere with (at least make wonky) Sharing.

jannellelegg commented 7 years ago

Thanks @mebrett for troubleshooting with me- disabling my adblocker/plugins seems to have resolved the left-alignment issue for Chrome for each of the themes.

Outstanding issues are:

Centerow (top) - buttons do not appear
Centerrow (bottom) - buttons are slightly out of alignment with the "Powered by Omeka S" text

jannellelegg commented 7 years ago

Update: The Center Row (top) issue has been resolved. The Center Row (bottom) still slightly unaligned but not a functional problem. See example

kimisgold commented 7 years ago

@jannellelegg Could you publish the site from the example? It's currently not viewable to those without a login to Megan's installation.

mebrett commented 7 years ago

I just made it public

mebrett commented 7 years ago

It looks to me as though both of the final issues in Jannelle's comments have been resolved.

zerocrates commented 7 years ago

Then I deem it closed

omeka-s-modules / Sharing

Testing new event options #31