search

omeka-s-modules / Sharing

Omeka S module for sharing content via 1) Social Media and 2) Embedding Omeka S content in other sites
GNU General Public License v3.0
4 stars 6 forks source link

Twitter JS gets loaded even when disabled #45

Closed ManOnDaMoon closed 5 months ago

ManOnDaMoon commented 5 months ago

https://github.com/omeka-s-modules/Sharing/blob/e66abd3c8f618129f101a66576e47227df385436/Module.php#L192

Hello!

I was wondering if there is any particular reason to load the twitter JS script even when it is not enabled in a site's settings? Other services' scripts are then loaded only when necessary in the loop that follows: https://github.com/omeka-s-modules/Sharing/blob/e66abd3c8f618129f101a66576e47227df385436/Module.php#L231

Daniel-KM commented 5 months ago

This is fixed in #44 .