Testing: New features - Githubissues

omeka-s-modules / Sharing

Omeka S module for sharing content via 1) Social Media and 2) Embedding Omeka S content in other sites

GNU General Public License v3.0

4 stars 6 forks source link

Testing: New features #46

Closed jimsafley closed 5 months ago

jimsafley commented 5 months ago

A few new features need testing:

"Single button" setting in site settings under "Sharing". This setting consolidates sharing buttons under one share icon.
"Sharing" page block layout. This layout displays sharing buttons on site pages.
"Sharing" resource block layout for item page and media page This layout displays sharing buttons on resource pages.

allanaaa commented 5 months ago

Using a page block and also having the site set to "top" or "bottom" means the button shows up twice:

Do you want to amend that to be more like the TOC block, where the default page display disappears when you use a page block?

allanaaa commented 5 months ago

I forget: is this supposed to appear on Faceted Browse pages, the Map Browse page, etc? It isn't at the moment. But I can note that in the docs if it's not intended.

allanaaa commented 5 months ago

The font-awesome icon for "Embed codes" isn't showing:

Same problem as usual - the font-weight needs to be set to "bold" or a higher number.

allanaaa commented 5 months ago

The behaviour is also not ideal for the page blocks when in a narrow space. Note the text overflows its own button. @kimisgold would you jump in on the CSS for this one?

jimsafley commented 5 months ago

Using a page block and also having the site set to "top" or "bottom" means the button shows up twice. Do you want to amend that to be more like the TOC block, where the default page display disappears when you use a page block?

I don't think this will be a problem. A site administrator would set "Sharon buttons placement" to "Using blocks" if they intend to add the buttons using blocks. If it does become a problem, we'll just advise them to change to "Using blocks."

I forget: is this supposed to appear on Faceted Browse pages, the Map Browse page, etc? It isn't at the moment. But I can note that in the docs if it's not intended.

Sharing buttons only appear on public site pages, and public item and media resource pages.

The font-awesome icon for "Embed codes" isn't showing:

@kimisgold Do you know what's happening here?

jimsafley commented 5 months ago

The outstanding style issues should not delay release. I'll make a separate issue pointing to this issue.