search

omeka-s-themes / centerrow

GNU General Public License v3.0
2 stars 14 forks source link

Translate "Other Media" #48

Closed giocomai closed 1 year ago

giocomai commented 3 years ago

On the item page, the text "Other Media" is not translated if the language is set to something other than English.

I see that the theme correctly asks for translation in /view/common/block-layout/item-with-metadata.phtml, but, as the string is apparently not present in core Omeka S, then it's not translated.

Not sure if missing translation should be reported here, on Transifex, on core, etc. - if here's not the right place, I'll welcome hints about where to look next (of course, in this specific case, I can hardcode the translated text, but long term, it's nice to have this right).

kimisgold commented 3 years ago

Thanks for pointing this out. Turns out we need to create the long term solution for this, so I've created the related issue for Omeka S.

kimisgold commented 1 year ago

We've now included this pattern and its strings in the Omeka S core, so I believe this issue is resolved. If there are any errant untranslated strings I've missed, please feel free to reopen.