Test banner setting

[kimisgold]

There is now a theme setting that allows users to select a banner image to appear across site views. In additional settings, they can control:

• the maximum height of the banner for both mobile and desktop widths
• where to position the image within the banner container when the container ratio has a much greater width than height

Note: we're testing this setting across a bunch of themes, and I decided to omit the contained width setting for Default, as it doesn't really fit the look of this theme.

This is on the master branch and should be tested on desktop and mobile browsers.

[katknow]

This works really well across desktop browsers. The only thing is that the search bar does sit on top right corner of the banner when fixed to top--I think it looks fine, but I don't know if it would matter to some folks/with specific banner images. While I can get the banner to appear and work fine on my iPhone, I cannot get it to appear under any circumstances using the Chrome developer tools so I wonder if there might be issues on other mobile devices.

[kimisgold]

I think the issue might have something to do with a margin style applying to mobile styles when it shouldn't. I've just pushed a fix that should be ready to test.

[katknow]

That fixed it in terms of showing up in the developer tools! This one also isn't following the selection for where to fix the banner, but while the other two had issues of fixing to the top this one seems to stay fixed on center on mobile.

[katknow]

Re-checked on mobile, seems good to go!