search

omeka-s-themes / default

GNU General Public License v3.0
2 stars 13 forks source link

Banner & Logo Behavior #31

Closed spswanz closed 2 years ago

spswanz commented 2 years ago

Is this expected behavior?

When I add an logo in the theme settings, the site Title does not display:

Screen Shot 2022-01-09 at 6 31 20 PM

Looking at the HTML, it seems the site title is given as the logo alt-text, but does not render on the page.

When I add a banner instead (no logo), I get the site title and the nav bar, but above the banner. I'd expect the title & nav to be below the banner (like it is for logo).

Screen Shot 2022-01-09 at 6 35 41 PM

Thanks

kimisgold commented 2 years ago

Yes this is expected behavior. Often logo graphics will be a wordmark that renders the site title redundant. The banner is more a presentation element. We placed the site title and navigation above it as they are key functional elements that shouldn't get buried under a decorative image.