search

omeka-s-themes / foundation

An Omeka S theme based off ZURB Foundation
GNU General Public License v3.0
7 stars 14 forks source link

Media embed block on horizontal #77

Closed allanaaa closed 4 days ago

allanaaa commented 1 week ago

I've got items in a horizontal media embed, and there is a "not last child" effect that's causing the thumbnails to mis-align.

I think you only want this margin-bottom on vertical, not horizontal?

Screenshot 2024-11-18 at 13 01 46

http://dev.omeka.org/amayer/amayer-s/omeka-s/s/my-fourth-site/page/testing-layouts

kimisgold commented 5 days ago

This is actually an issue stemming from the default styles provided by the core. If you pull latest changes from the core now, there should be a fix in place.

allanaaa commented 5 days ago

I'm not seeing any change, sorry. I cleared my cookies and everything! Looked at it in Chrome too.

Screenshot 2024-11-20 at 14 38 02

I also realized that when logged-out the page is showing an error about an item that can't be found - this appears to be an issue with Hierarchy, so I'll make an issue there - just wanted to mention it if you tried to see that page but couldn't.

kimisgold commented 5 days ago

I'm seeing the change on your link. It might require another cache clear on your end?

allanaaa commented 4 days ago

Okay, we're good, finally! It was still doing it in multiple browsers yesterday, but today it's working fine.