search

omeka-s-themes / freedom

An Omeka S Theme
GNU General Public License v3.0
2 stars 4 forks source link

Translation issues #29

Open giocomai opened 5 months ago

giocomai commented 5 months ago

There are some issues with the translation of the (very nice) Freedom theme.

In some cases, the issue is clear, as the theme requests the translation, but the string is not available, e.g.

'Showing %1$s to %2$s of %3$s %4$s' '< Previous page' 'Next page >'

or, in the theme settings page, for example the following are missing:

In the settings, all of Truncate Body Property options are missing, and actually, most of the setting page remains untranslated.

Should these be added to Omeka core translation files in Transifex?

In other cases, the translation would be available, but the value is hardcoded in the theme, e.g. the hardcoded "advanced search" in header.phtml, which can be easily fixed (this one is currently very visible, as it is by default at the top of any website using the theme).

There is also the "go" button of the pagination (pagination.phtml) <input type="submit" class="gotopage-btn" value="Go">

Finally, there are untranslated text string also in javascript files, in particular in accordion.js, "Expand all" and "Collapse all", which appears when listing related resources.

I may be missing others.

nelsonamaya82 commented 5 months ago

@giocomai thanks for reporting this, I'll start reviewing it with the team.

giocomai commented 4 months ago

I found other untranslated strings in navigation.js:

If I find others, I will edit this comment.

As a note, I noticed that pages already load a Omeka.jsTranslate = function(str), wich references js_translate_strings in the core codebase, so I suppose that could be a way to got about it...