Misc

[allanaaa]

Re https://github.com/omeka-s-themes/lively/issues/1

1) I don't think we need an arrow next to menu content that doesn't have any sub-items:

If you want to keep the arrows for style, I would move them to before the text - in line with your list styles (see below) and to keep people from thinking they will expand and collapse the way arrows do in other Omeka themes.

2) Your left-hand pink title decoration doesn't always respect the height of the title container:

3) Your list styles are a bit different (here is the TOC page block below the new Item Hierarchy block), not sure why:

In the code, one is being modified with ::marker and the other isn't - not sure if this is something the new module needs to refer to, or if your theme should be covering all list instances:

4) The sorting buttons on the item set browse page should be longer instead of cutting off text:

They look fine on item browse:

5) I wouldn't have two Advanced Search links so close by each other, seems redundant. It doesn't appear that I have the option to hide that, or to hide the top bar when empty.

6) The map pin suggests to me this is a link to a map coordinate - any way to add links to that contact field? The other two work fine, though I want help text in the admin side to say that they will become live links.

[allanaaa]

7. In media blocks, the title below the media sits underneath the decorative border. I'm not a fan of it sitting on top of the content either - it should match the other tiles IMO.

   

8. What determines whether an image flows past its container? Any way to turn that off? I'm not a fan of it happening sometimes but not all the time.

   

[allanaaa]

9. I have issues with resource regions in this theme. The "Main" region is not significantly wider than the "left sidebar" and "right sidebar" at full browser widths, and you don't even really see that layout unless you're at 1200px or wider, right? And then from 1440px up you don't expand the main region any more, just add whitespace on either side. Sort of hard to use our blocks to their fullest potential. I mean lightbox gallery, map, media render - basically any site with decent graphics is not going to want 3 columns, and any site that's only text may not want 3 columns either, because that's just busy.
10. Does it need to be a 1-column layout when narrowed? Or can it go down to 2 columns first?
11. Can we rename the regions, "Center" instead of "Main"?
12. I would also put some help text somewhere to indicate that it'll be Main, then Left, then Right, when the browser is any narrower than 1200px.

[nelsonamaya82]

@allanaaa all the issues are fixed, except a few ones detailed below:

1. Fixed.
2. Fixed.
3. The style in the ToC block is intended to be different as it's a different kind of list, specific for this block, compared to the rest of lists (standard styling).
4. Fixed.
5. Initialy the top bar was hidden when there was no contact information (or when the contact info visibility option was set to the Footer only) but then after a review with the team, Sharon sugested to keep this top bar always visible. Anyway, when you scroll down, the top bar hides automatically so you cannot see the Advanced Search link again (unless you scroll up back), so it's important to have this link available in the search box: advanced-search.webm
6. Fixed.
7. Fixed.
8. The default behavior is that images flow past its container, however when the text in front of the image is equal or larger than the image height, the container has to adapt to the text, making the container larger than the image.
9. For cases where resource regions have 2 sidebars, I reduced the sidebars width by a 10% so the main region is now 60% wide while the sidebars are 20% each. When there's only one sidebar, the main region is 70% and the sidebar 30%. The media query breakpoint is set at 1200px so yes, the layout is only visible on screens wider than 1200px (basically every desktop screen). A narrower screen would be a tablet or mobile device, so the sidebars and main region are stacked vertically. The main container on this theme is 1440px, so all contents, regions, blocks, etc. are constrained to this width. So if the intention of a site is to use big graphics, I wouldn't use a 3-column layout but just a single sidebar and main region.
10. I think it doesn’t look good on narrow screens if we had the left sidebar and the main region in the same row, and then the right sidebar below them. However I tried this and having 2 columns first on narrow screens (below 1200px) makes the content look so tight. Anyway, resolutions between 1024px and 1200px are not so common. Most of devices are whether below 1024px (tablets in portrait mode and mobile devices) or above 1200px (tablets in landscape mode and desktop).
11. Fixed.
12. I couldn't find a way to add a description to the "Configure resource pages" page from the theme's config file, I think there isn’t an option to do that currently. I'll double check with John though.

[allanaaa]

I have a submission form page created by the Collecting module, where the margins around the fields seem to be missing:

http://dev.omeka.org/amayer/amayer-s/omeka-s/s/my-third-site/page/submissions

Compare to the way the dotted border sits on the Advanced Search page:

http://dev.omeka.org/amayer/amayer-s/omeka-s/s/my-third-site/item/search

[allanaaa]

On this page, I'm getting the IIIF viewer exceeding the page width, as well as its own grid span setting:

http://dev.omeka.org/amayer/amayer-s/omeka-s/s/my-second-site/page/my-12-column-grid-page

There's a full-page-width one near the bottom of the page.

There's actually two - one set up to "vertical" (expanding past the browser width) and one set to "horizontal" (that's very narrow). That one's behaving "correctly" because it's restricting itself to a 4-item grid, which ... you may not want? I would think 1, 2, or 3 media selected could take up flex space.